Updates for Makerfabs TFT 7" touch dotclock panel #8625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makerfabs obtained a Product ID from Espressif but they only requested a single ID rather than an ID for each of the resolutions. I've been using @jepler's original 800x480 build with just the resolution changes from this PR on the 1024x600 tablet, so I believe the two resolution tablets are functionally identical other than the screen resolution.
This PR adds the timing tables for both resolutions so the user can select the proper timing definition for their particular tablet, however if two board definitions is preferred, I can go back to Makerfabs and ask again for two separate PID's.
I also noticed what looks like a couple of copy paste bugs in ports/espressif/common-hal/microcontroller/Pin.c. They are not particularly consequential however I believe the extra GPIO19 and GPIO20 never reset definitions would prevent a CIRCUITPY_USB=0 build from working.
As it turns out, a CIRCUITPY_USB=0 build could be useful on this board as the designers shared the USB D+/D- pins as exposed GPIO pins and with the I2S audio circuit. I added comments for building with the USB disabled allowing the use of the I2S feature and made guesses at reasonable CREATOR/CREATION IDs.
I'm looking for direction as to whether I should leave the USB=0 information in mpconfigboard.mk and if so, the best way to get CREATOR/CREATION IDs that I can submit to https://github.com/creationid/creators