Synthio: Allow amplitude to be signed (+ other stuff) #8642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, negative amplitudes were clamped to zero. Now, they are allowed to range from -ALMOST_ONE to +ALMOST_ONE. This is useful in certain circumstances, such as using synthio to create CV-like outputs that can be positive or negative, by using the amplitude property of the note.
some of the numbers have the last two digits changed, it's just noise.
tannewt
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #8564 (ping @CedarGroveStudios)
While working on this issue, I noticed that the "circuitpython" tests were not being run by "make test" and therefore not during CI. (this probably happened during one of the recent micropython merges; I marked the changes as CIRCUITPY-CHANGE) There were several problems with the tests themselves. I fixed them, updated some expected outputs, and restored running the tests when expected.
The final unrelated change to tools/git-checkout-latest-tag.sh ensures that if a tag isn't fetched, the script exits with an error. It's intended that all frozen modules have to be at a tag, but this script would run without errors even if no tags were available.