Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add branch and PR number to uploaded build filenames #8648

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

dhalbert
Copy link
Collaborator

Fixes #8321.

Adds more information to uploaded build filenames, e.g.:
was

adafruit-circuitpython-adafruit_feather_esp32s2-en_US-20231122-b2c32cf.uf2

will be

adafruit-circuitpython-adafruit_feather_esp32s2-en_US-20231122-main-PR8645-b2c32cf.uf2

@dhalbert dhalbert force-pushed the branch-name-in-build-filename branch 3 times, most recently from af4722c to bdf4b7f Compare November 22, 2023 15:09
@dhalbert dhalbert force-pushed the branch-name-in-build-filename branch from bdf4b7f to 0bd2a37 Compare November 22, 2023 15:51
@dhalbert
Copy link
Collaborator Author

Now working, for example:
adafruit-circuitpython-adafruit_feather_esp32s2-en_US-20231122-main-PR8648-140f910.uf2 in artifacts

Hopefully will continue to work on upload to S3 when merged.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement, thanks.

@dhalbert dhalbert merged commit 3aac226 into adafruit:main Nov 24, 2023
471 checks passed
@dhalbert dhalbert deleted the branch-name-in-build-filename branch November 24, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a git tag and/or PR number to artifact and PR merge build filenames
2 participants