-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new board: Cytron Maker UNO RP2040 #8649
Add new board: Cytron Maker UNO RP2040 #8649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi - one typo, and pre-commit says there are blank lines with trailing spaces in pins.c
. See https://learn.adafruit.com/building-circuitpython/build-circuitpython#install-pre-commit-3096511 for more information about using pre-commit locally to catch these kinds of things.
You can also set some editors to automatically remove trailing spaces and trailing blank lines.
Co-authored-by: Dan Halbert <halbert@halwitz.org>
Hi @noqman -
I would fix these for you but you have not given permission for maintainers to push to your PR branch. |
cec9791
to
265b703
Compare
Hi, I have implemented all your suggestions. Please let me know if any further revisions or changes are needed. Thank you and I truly appreciate your guidance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks fine. Thanks for your patience with the formatting changes!
Hi,
Can you please help to add this new board : Cytron Maker UNO RP2040 ?
Thanks