Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board: Cytron Maker UNO RP2040 #8649

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

noqman
Copy link

@noqman noqman commented Nov 22, 2023

Hi,

Can you please help to add this new board : Cytron Maker UNO RP2040 ?

Thanks

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - one typo, and pre-commit says there are blank lines with trailing spaces in pins.c. See https://learn.adafruit.com/building-circuitpython/build-circuitpython#install-pre-commit-3096511 for more information about using pre-commit locally to catch these kinds of things.

You can also set some editors to automatically remove trailing spaces and trailing blank lines.

ports/raspberrypi/boards/cytron_maker_uno_rp2040/pins.c Outdated Show resolved Hide resolved
Co-authored-by: Dan Halbert <halbert@halwitz.org>
@dhalbert
Copy link
Collaborator

Hi @noqman -
There are still two problems with the formatting. See https://github.com/adafruit/circuitpython/actions/runs/6967019048/job/18958156375?pr=8649

  1. mpconfigboard.mk needs a single newline at the end.
  2. There are lines that consist solely of spaces in pins.c.

I would fix these for you but you have not given permission for maintainers to push to your PR branch.

@dhalbert
Copy link
Collaborator

I'm not sure what happened. Your commit f2b39ae contained some extraneous changes unrelated to to your new board. Merging from upstream did not fix that. If you git reset --hard back to 6d02f12 and then just fix mpconfigboard.mk and pins.c and git push -f, I think it will be OK.

@noqman
Copy link
Author

noqman commented Nov 30, 2023

Hi, I have implemented all your suggestions. Please let me know if any further revisions or changes are needed.

Thank you and I truly appreciate your guidance.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks fine. Thanks for your patience with the formatting changes!

@dhalbert dhalbert merged commit d7014d9 into adafruit:main Nov 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants