Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve web workflow error handling #8667

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Nov 28, 2023

  • Disable Nagle at the end of error messages so they are sent before the socket is closed.
  • Correctly discard file contents when the PUT file is too large.
  • Correctly reset file size after failure to setting it too large.
  • Change diskinfo.json to be list of disks in preparation of supporting multiple disks.
  • Bump version to 3 for the above change.
  • Document diskinfo.json.

Fixes #8109

* Disable Nagle at the end of error messages so they are sent before
  the socket is closed.
* Correctly discard file contents when the PUT file is too large.
* Correctly reset file size after failure to setting it too large.
* Change diskinfo.json to be list of disks in preparation of supporting
  multiple disks.
* Bump version to 3 for the above change.
* Document diskinfo.json.

Fixes micropython#8109
@tannewt tannewt added this to the 9.0.0 milestone Nov 28, 2023
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo and a question

docs/workflows.md Outdated Show resolved Hide resolved
supervisor/shared/web_workflow/web_workflow.c Show resolved Hide resolved
Co-authored-by: Dan Halbert <halbert@halwitz.org>
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dhalbert dhalbert merged commit c3f8e0f into adafruit:main Nov 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading a file that is too large via Web Workflow causes Hard Fault
2 participants