Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flipper Zero Wi-Fi Dev board #8673

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Support for Flipper Zero Wi-Fi Dev board #8673

merged 4 commits into from
Dec 6, 2023

Conversation

maewolfsky
Copy link

Added board support for the ESP32-S2-WROVER based Flipper Zero Wi-Fi Dev board

@anecdata
Copy link
Member

anecdata commented Nov 30, 2023

Where did the Espressif PID come from? Typically, third-party boards using Espressif's VID will request custom PIDs here:
https://github.com/espressif/usb-pids

@maewolfsky
Copy link
Author

maewolfsky commented Nov 30, 2023

The pid came from lsusb with the stock firmware.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-check which pins are usable. I noted some unneeded pins but did not thoroughly review.

ports/espressif/boards/flipperzero_wifi_dev/pins.c Outdated Show resolved Hide resolved
@@ -0,0 +1,16 @@
USB_VID = 0x303A
USB_PID = 0x4001
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned that this is the existing PID: do you mean on the Flipper Zero or on the WiFi module only?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the wifi dev board has its stock firmware, thats where I got the vid,pid

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the IDF default PID: https://github.com/espressif/idf-extra-components/blob/master/usb/esp_tinyusb/usb_descriptors.c#L11-L21

I wouldn't use it though because CircuitPython presents different interfaces than what 0x4001 is for. Please request a custom PID from Espressif: https://github.com/espressif/usb-pids

@maewolfsky maewolfsky marked this pull request as draft December 1, 2023 00:25
Suggestions applied

Co-authored-by: Dan Halbert <halbert@halwitz.org>
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are you ready to merge? If so, remove it from draft status and we'll merge, and you can proceed on the circuitpython-org PR as well.

@maewolfsky
Copy link
Author

@dhalbert I'm double checking some pins, and want to do some quick testing; but pretty much done. Thanks for the help!

@dgriswo
Copy link

dgriswo commented Dec 1, 2023

Will this need a PR to TinyUF2 as well?

@dhalbert
Copy link
Collaborator

dhalbert commented Dec 1, 2023

Will this need a PR to TinyUF2 as well?

It should not. New boards do not need to be added to TinyUSB. Were you thinking of something specific?

@dgriswo
Copy link

dgriswo commented Dec 1, 2023

Will this need a PR to TinyUF2 as well?

It should not. New boards do not need to be added to TinyUSB. Were you thinking of something specific?

Since the board doesn't ship with a UF2 bootloader on flash, wouldn't one always need to use esptool for any install/updates? (it is ESP32-S2 based, so there isn't a UF2 bootloader in ROM)

@dhalbert
Copy link
Collaborator

dhalbert commented Dec 1, 2023

Sorry I misread TinyUF2 as TinyUSB. There are some existing UF2 bootloaders that could be used, since it's a standard module. So not necessary, but could be done to get the LEDs to work.

@maewolfsky maewolfsky marked this pull request as ready for review December 5, 2023 22:54
@maewolfsky
Copy link
Author

I'm actually done with changes this time :)

@jepler jepler merged commit 12d820d into adafruit:main Dec 6, 2023
15 checks passed
@tannewt
Copy link
Member

tannewt commented Dec 6, 2023

@maewolfsky Please request a new PID from espressif and make a new PR. I think using the same PID will confuse the host computer because the USB descriptor is different from the default firmware.

@anohope
Copy link

anohope commented Dec 29, 2023

Hey, I'm new to all this so bare with me. I bought an esp32 + nfc24 multi Board v2. I want to flash marauder to it, but it doesn't have a USB port. Is there another way?

@anecdata
Copy link
Member

@anohope this really isn't the place for support questions. try the forums for the hardware or software manufacturer, or the Adafruit Discord: https://adafru.it/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants