-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Flipper Zero Wi-Fi Dev board #8673
Conversation
Where did the Espressif PID come from? Typically, third-party boards using Espressif's VID will request custom PIDs here: |
The pid came from lsusb with the stock firmware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-check which pins are usable. I noted some unneeded pins but did not thoroughly review.
@@ -0,0 +1,16 @@ | |||
USB_VID = 0x303A | |||
USB_PID = 0x4001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned that this is the existing PID: do you mean on the Flipper Zero or on the WiFi module only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the wifi dev board has its stock firmware, thats where I got the vid,pid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the IDF default PID: https://github.com/espressif/idf-extra-components/blob/master/usb/esp_tinyusb/usb_descriptors.c#L11-L21
I wouldn't use it though because CircuitPython presents different interfaces than what 0x4001 is for. Please request a custom PID from Espressif: https://github.com/espressif/usb-pids
Suggestions applied Co-authored-by: Dan Halbert <halbert@halwitz.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Are you ready to merge? If so, remove it from draft status and we'll merge, and you can proceed on the circuitpython-org
PR as well.
@dhalbert I'm double checking some pins, and want to do some quick testing; but pretty much done. Thanks for the help! |
Will this need a PR to TinyUF2 as well? |
It should not. New boards do not need to be added to TinyUSB. Were you thinking of something specific? |
Since the board doesn't ship with a UF2 bootloader on flash, wouldn't one always need to use esptool for any install/updates? (it is ESP32-S2 based, so there isn't a UF2 bootloader in ROM) |
Sorry I misread TinyUF2 as TinyUSB. There are some existing UF2 bootloaders that could be used, since it's a standard module. So not necessary, but could be done to get the LEDs to work. |
I'm actually done with changes this time :) |
@maewolfsky Please request a new PID from espressif and make a new PR. I think using the same PID will confuse the host computer because the USB descriptor is different from the default firmware. |
Hey, I'm new to all this so bare with me. I bought an esp32 + nfc24 multi Board v2. I want to flash marauder to it, but it doesn't have a USB port. Is there another way? |
@anohope this really isn't the place for support questions. try the forums for the hardware or software manufacturer, or the Adafruit Discord: https://adafru.it/discord |
Added board support for the ESP32-S2-WROVER based Flipper Zero Wi-Fi Dev board