rgbframebuffer: round up internal size to multiple of 16 pixels #8698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a (width + left_overscan) of 360, e.g., debug info shows the following: ``` E (3410) cache: esp_cache_msync(35): size isn't aligned with the data cache line size (32)B E (3410) lcd_panel.rgb: rgb_panel_draw_bitmap(742): flush cache buffer failed ``` Internally add extra pixels as needed at the end of a pixel row, like an automatic overscan_right. This may not be compatible with all panels, but there's not really another alternative with this peripheral. So let's try this! Closes: adafruit#8697
makermelissa
reviewed
Dec 5, 2023
makermelissa
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a (width + left_overscan) of 360, e.g., debug info shows the following:
Internally add extra pixels as needed at the end of a pixel row, like an automatic overscan_right.
This may not be compatible with all panels, but there's not really another alternative with this peripheral. So let's try this!
Closes: #8697