Handle 4way handshake error in idf5 #9025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Mar 11, 2024
anecdata
reviewed
Mar 14, 2024
There was a problem hiding this comment.
I think the else if here (lines 378-388) is redundant: the new if handles the special case, the else if would get handled anyway by the return self->last_disconnect_reason;? It's been that way for a while it seems, nothing new.
edit: I'm fine with this solution, it all bubbles up to a ConnectionError: Authentication failure in shared-bindings, so users do get a descriptive string for these cases.
dhalbert
previously requested changes
Mar 14, 2024
Co-authored-by: Dan Halbert <halbert@halwitz.org>
This reverts commit 6c14264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8888
Turns out the error did occur in any authentication mismatch.
I investigated the underlying api a bit and played with examples, and saw a lot more weirdness there.
When attempting to connect to a secure wifi without a password,
event_idbecomes 2 andevent_data.reasonis 15 (WIFI_REASON_4WAY_HANDSHAKE_TIMEOUT).When attempting to connect to a secure wifi with an incorrect password,
event_idbecomes 5 andevent_data.reasonis 15 (WIFI_REASON_4WAY_HANDSHAKE_TIMEOUT).I don't know if the upstream change in behavior is intentional, and I don't have the time to find that out right now.
This is a simple patch that when it sees 15 (
WIFI_REASON_4WAY_HANDSHAKE_TIMEOUT) it makes it 202 (WIFI_REASON_AUTH_FAIL).