Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lolin s3 pro #9030

Merged
merged 4 commits into from Mar 13, 2024
Merged

Add lolin s3 pro #9030

merged 4 commits into from Mar 13, 2024

Conversation

PaulskPt
Copy link

To add a new board, Lolin S3 PRO, yet not existing in circuitpython.org/downloads. @tannewt advised me to add this board and to create a PR.

@PaulskPt PaulskPt changed the title Paulskpt lolin s3 pro Add lolin s3 pro Mar 10, 2024
tannewt
tannewt requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. There is one extra file.

ports/silabs/gecko_sdk Outdated Show resolved Hide resolved
tannewt
tannewt approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 5c89169 into adafruit:main Mar 13, 2024
12 checks passed
@PaulskPt PaulskPt deleted the paulskpt_lolin_s3_pro branch March 13, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PaulskPt @tannewt