Turn on bitmapfilter with the same criteria as bitmaptools #9156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
previously approved these changes
Apr 8, 2024
BlitzCityDIY
previously approved these changes
Apr 8, 2024
dhalbert
force-pushed
the
bitmapfilter-on-if-bitmaptools-on
branch
from
316a992
to
a48be88
Compare
|
The last word on this is that it's turned on with boards with displayio and >4MB flash, more or less. Otherwise there are many boards it can't fit on. It is on for MatrixPortal S3. |
jepler
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitmapfilteris useful for display output as well as for camera image processing. @BlitzCityDIY would like to try it on the Matrix Portal S3. @FoamyGuy suggested enabling it ifbitmaptoolsis enabled. This PR does that.FYI, in terms of space,
bitmaptoolstakes about 12kB, andbitmapfiltertakes about 6kB.