Update pin names to match info printed on board #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kylefmohr I meant to tag you here.... |
Good catch by @bablokb - Also your changes LGTM! Thanks @RetiredWizard |
dhalbert
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Thanks @RetiredWizard and @bablokb!
I don't think a backport to 9.0.x of ESP32-S3 Geek is needed. If you want to fix 9.0.x RP2040 Geek, that's fine. I won't make a release right away, since it's a minor change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the ESP-S3-GEEK and RP2040-GEEK boards are both currently using the Espressif pin naming convention (IOxx), @bablokb pointed out to me that the devices themselves have the pin labels printed on them and they are using the Raspberry Pi RP2040 pin naming convention (GPxx). This PR will update CircuitPython so the pin names match what is printed on the devices.
Only the RP2040-GEEK has been ported to the 9.0.x branch, so I'll submit a second PR to update that branch. @dhalbert Let me know If it would be helpful for me to back port the ESP-S3-GEEK to the 9.0.x branch in that PR as well.