Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few regexps that are better as raw strings #9267

Merged
merged 1 commit into from
May 22, 2024

Conversation

dhalbert
Copy link
Collaborator

@elpekenin noticed this problem:

$ make fetch-all-submodules 
python3 tools/ci_fetch_deps.py all
/home/elpekenin/circuitpython/tools/ci_fetch_deps.py:14: SyntaxWarning: invalid escape sequence '\.'
  version_str = re.search("([0-9]\.*)*[0-9]", version_str).group(0)

That regexp should be a raw string. The vast majority of regexp strings are now raw strings, but I found a few more. A new were not really necessary, but made them raw strings for consistency, and one is easier to understand as a raw string.

@dhalbert dhalbert requested review from tannewt and jepler May 22, 2024 14:26
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 1382006 into adafruit:main May 22, 2024
513 checks passed
@dhalbert dhalbert deleted the fix-re-escape-warnings branch May 22, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants