Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi Library Name Resolution Differes from Learn Bundler #200

Closed
FoamyGuy opened this issue Feb 29, 2024 · 0 comments · Fixed by #201
Closed

PyPi Library Name Resolution Differes from Learn Bundler #200

FoamyGuy opened this issue Feb 29, 2024 · 0 comments · Fixed by #201

Comments

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Feb 29, 2024

This was noted originally here: adafruit/Adafruit_CircuitPython_Requests#157

With the current logic inside of circup this pypi name "Adafruit-Circuitpython-ConnectionManager" gets converted to this import name "adafruit_connectionmanager" which is is missing an underscore between connection and manager which results in circup raising this error:

WARNING:
	adafruit_connectionmanager is not a known CircuitPython library.

The learn system bundler does seem capable of handling the current naming. This is a project bundle link for a pyportal project: https://learn.adafruit.com/elements/3055357/download?type=zip and it does include adafruit_connection_manager.mpy in the downloaded zip.

It would be good if circup can have another step in it's logic to convert the names so that it can correctly find this library in the same way that the bundler has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant