Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find all files in packages #159

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Jan 31, 2023

When circup looks at the board libraries it reads them all to find the version number and incompatible or invalid MPY files.
But it only looked at the first level files. This PR makes it look at all levels using the **/ pattern and recursive glob option.

At least one library, adafruit_displayio_layout has no file at the first level that contain version information (only an empty init).

before

❯ circup freeze
Found device at /Volumes/CIRCUITPY, running CircuitPython 8.0.0-beta.6-62-g7522522a0-dirty.
adafruit_displayio_layout==None

after

❯ circup freeze
Found device at /Volumes/CIRCUITPY, running CircuitPython 8.0.0-beta.6-62-g7522522a0-dirty.
adafruit_displayio_layout==1.19.10

Copy link
Contributor

@askpatrickw askpatrickw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me compared to the Glob library docs.
Not tested.

@jposada202020
Copy link
Contributor

@dhalbert this is why we still have the problem in the displayio_layout. change never got merged. :(

@jposada202020
Copy link
Contributor

@Neradoc could you take a look, not sure what is need to be done here TBH

@Neradoc
Copy link
Contributor Author

Neradoc commented Mar 21, 2023

Rebased

@jposada202020 jposada202020 merged commit 4015574 into adafruit:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants