Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGES.rst To PyPI Manifest #18

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Add CHANGES.rst To PyPI Manifest #18

merged 2 commits into from
Oct 4, 2019

Conversation

sommersoft
Copy link
Collaborator

As noted in #17, setup.py fails when installing from PyPI because CHANGES.rst is not distributed. This adds a MANIFEST.in file, which should force the file to be distributed.

Note: after merge, use tag 0.0.3 when releasing to match this with the version that will be annotated in PyPI.

makermelissa
makermelissa approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa makermelissa merged commit e6c79c6 into adafruit:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

@ntoll ntoll Awaiting requested review from ntoll

@siddacious siddacious Awaiting requested review from siddacious

@ladyada ladyada Awaiting requested review from ladyada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sommersoft @makermelissa