Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump semver to 3.0.x #185

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

imnotjames
Copy link
Contributor

Updates requirements.txt and setup.py to reference semver for the next major release, 3.0.0

There are no code changes needed to support this as circup doesn't use any of the deprecated
features, or so it seems. The biggest change here from what I can tell is that python 2 is no longer supported.

pytest results:

=================================================================================== test session starts ===================================================================================
platform linux -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0
rootdir: /home/james/Projects/imnotjames/circup
plugins: hypothesis-6.88.1
collected 50 items                                                                                                                                                                        

tests/test_circup.py ..................................................                                                                                                             [100%]

==================================================================================== warnings summary =====================================================================================
circup/__init__.py:23
  /home/james/Projects/imnotjames/circup/circup/__init__.py:23: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources

../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
../../../../../usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871
  /usr/lib/python3.11/site-packages/pkg_resources/__init__.py:2871: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('zope')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
    declare_namespace(pkg)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================================= 50 passed, 8 warnings in 0.32s ==============================================================================

The warnings seem to be unrelated to this change.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit e73a094 into adafruit:main Oct 30, 2023
1 check passed
@aricooperdavis
Copy link
Contributor

I believe this has broken circup due to the breaking change of the isvalid() method to is_valid(). See #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants