Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toml to dependency list #192

Merged
merged 1 commit into from
Nov 13, 2023
Merged

add toml to dependency list #192

merged 1 commit into from
Nov 13, 2023

Conversation

FoamyGuy
Copy link
Contributor

resolves #191

Tested in an empty venv and with this change I'm able to use circup immediately after installing.

@FoamyGuy FoamyGuy requested a review from a team November 13, 2023 21:12
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense with what I know about python dependency tracking. there may be a way to share the content between setup.py and requirements.txt but it's not worth the trouble.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tekktrik
Copy link
Member

makes sense with what I know about python dependency tracking. there may be a way to share the content between setup.py and requirements.txt but it's not worth the trouble.

A quick check of setup.py shows it should be a simple conversion to a pyproject.toml file that would make that change easy!

@FoamyGuy FoamyGuy merged commit 5f1e6ab into adafruit:main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toml not installed with pip install circup==1.5.0
3 participants