Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renamed is_valid() method call #194

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix renamed is_valid() method call #194

merged 1 commit into from
Nov 16, 2023

Conversation

aricooperdavis
Copy link
Contributor

@aricooperdavis aricooperdavis commented Nov 16, 2023

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.

This change fixes a bug with the code following a change to the semver package which renames the isvalid() method to is_valid(). Fixes #193

  • Describe any known limitations with your change.

n/a

  • Please run any tests or examples that can exercise your modified code.

n/a

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@dhalbert dhalbert merged commit e3d2665 into adafruit:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semver package breaking change: isvalid() -> is_valid()
2 participants