Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update import #212

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Update import #212

merged 1 commit into from
Apr 30, 2024

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Apr 30, 2024 •
edited

With the merging of adafruit/Adafruit_CircuitPython_ESP32SPI#198, this:

import adafruit_esp32spi.adafruit_esp32spi_socket as socket

No longer exists.

As the imports are fake, it doesn't actually cause the tests to fail, but if it ever changed in the future, it would.

@justmobilize justmobilize marked this pull request as ready for review April 30, 2024 17:03
@justmobilize
Copy link
Contributor Author

@dhalbert a simple update for sanity later

dhalbert
dhalbert approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit fdf824d into adafruit:main Apr 30, 2024
1 check passed
@justmobilize justmobilize deleted the update-import branch April 30, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justmobilize @dhalbert