Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version overriding arg #219

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

FoamyGuy
Copy link
Contributor

resolves #218

If --cpy-version CLI argument is passed by user, then pass it's value to the Backend constructor and store it in a local variable to be returned if it exists from get_circuitpython_version()

I was able to successfully test this version with these commands:

circup --path fake_project/ --cpy-version 8.0.0 --board-id hello install adafruit_display_text
circup --path fake_project/ --cpy-version 9.0.0 --board-id hello install adafruit_display_text

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 74b07be into adafruit:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Directory (Non-Device) Commands Are Broken
2 participants