compiles and runs #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
requested changes
Oct 26, 2023
|
|
||
| #ifdef HAVE_TOUCHPAD | ||
| Serial.println("Initializing touch screen..."); | ||
| if (!ts.begin()) { | ||
| if (!ts.begin(0x48, &Wire)) { |
There was a problem hiding this comment.
Need to add preproc logic here to call the STMP begin. This worked with local testing:
#ifdef TOUCH_CS
if (!ts.begin()) {
#else
if (!ts.begin(0x48, &Wire)) {
#endif
Comment on lines
+6
to
+10
| #ifdef TOUCH_CS | ||
| #include <Adafruit_STMPE610.h> | ||
| #else // use I2C | ||
| #include <Adafruit_TSC2007.h> | ||
| #endif |
There was a problem hiding this comment.
For some Arduino reason, the #define of TOUCH_CS in settings.h is not being seen here. So the logic always #includes the TSCC2007 header and the build fails at link time.
Suggest moving the #define of TOUCH_CS to this file and place immediately above this preproc logic. Can then add a comment in settings.h that this needs to be done for STMP. This worked with local testing.
|
sorry guys...this is all clear as mud to old simple over 60 people like me. anyway to get updated files with all the corrections and changes so I can download compile and run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes compile errors and works with TSC2007 now