Added AWS Certs #21
Merged
Added AWS Certs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AmazonRootCA1 and AmazonRootCA3 for AWS IoT
brentru
requested changes
Jun 11, 2020
There was a problem hiding this comment.
@virgilvox Thanks for the PR, I thought the root certs. for AWS were included. I'd like to get this merged in to a build and bump the nina-fw to v1.6.1.
Could you make a few changes:
- Please change
NINA_W102-1.6.0.bintoNINA_W102-1.6.1.bin
https://github.com/adafruit/nina-fw/blob/master/Makefile#L31 - Change
outputFilename = "NINA_W102-1.6.0.bin"tooutputFilename = "NINA_W102-1.6.1.bin"
https://github.com/adafruit/nina-fw/blob/master/combine.py#L34 - Change
const char FIRMWARE_VERSION[6] = "1.6.0";toconst char FIRMWARE_VERSION[6] = "1.6.1";
https://github.com/adafruit/nina-fw/blob/master/main/CommandHandler.cpp#L31
Thanks!
|
Changes submitted! I tested a build of the firmware yesterday and it worked. Turns out the AWS Cert that was already in there is legacy. So I added the latest. |
brentru
approved these changes
Jun 11, 2020
|
@virgilvox thanks for updating the latest certs.! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AmazonRootCA1 and AmazonRootCA3 for AWS IoT