Lengthen I2C SDA TX hold time #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the checks are skipped. @tannewt, do we need to enable something? |
You're welcome 😃 |
dhalbert
force-pushed
the
fivdi-sda-tx-hold-time
branch
from
a06b572
to
e258d99
Compare
dhalbert
force-pushed
the
fivdi-sda-tx-hold-time
branch
from
e258d99
to
b7e3827
Compare
ladyada
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
verified its the same as https://github.com/raspberrypi/pico-sdk/pull/273/files !
I don't know why they aren't on. |
|
I think they are being skipped because of this: pico-sdk/.github/workflows/cmake.yml Line 10 in fc10a97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate @fivdi's fix that increases the SDA TX hold time from 1 to 2, as proposed in raspberrypi#273.
This allows the TCS34725 to operate properly. No other sensors have yet appeared to need this fix, but this is a popular sensor.
I took Saleae traces with and without this fix, and aside from the sensor working properly, I don't see any issues. There is no visible slowdown of I2C transactions, for instance.
Thank you, @fivdi!
A step toward fixing adafruit/circuitpython#4082.