Allow much more time for xosc to start #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Dan and Scott, Does this merge mean that the latest stable releases of circuit python have this 64X delay built in? |
|
Yes, I believe so. I do think it is configurable so a board may not have it enabled. |
|
We are not using this fork right now. We are using https://github.com/raspberrypi/pico-sdk, which has raspberrypi#457, which does it per board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain board samples require much more time for their XOSCs to start up and become stable. This problem was noticed on several samples of QT Py RP2040.
This PR lengthens the startup time in
xosc_init()by a factor of 64. 16 is known to be not enough. 32 worked, so 64 is an additional safety margin.In the long run, there should probably be an API or compile-option change to fix this proposed to upstream.
Much discussion in raspberrypi#401.