Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor STM32 flashers #289

Merged
merged 2 commits into from Mar 1, 2023
Merged

Refactor STM32 flashers #289

merged 2 commits into from Mar 1, 2023

Conversation

zvecr
Copy link
Contributor

@zvecr zvecr commented Feb 25, 2023 •
edited

Description of Change

  • Support erase for dfu-util
    • Moved to common location to avoid duplication
  • Allow use of st-flash CLI as an alternative to STM32_Programmer_CLI

hathach
hathach requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, though I think we should add an additional flash-stflash and erase-stflash instead of using the current stlink. What do you think ?

@zvecr
Copy link
Contributor Author

zvecr commented Mar 1, 2023 •
edited

I did have that previously, and its use can be hidden with a :flash alias at the board level. Though I do think its somewhat unintuitive for flash-stlink to not work with the connected stlink.

hathach
hathach approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you

@hathach hathach merged commit 9d9c309 into adafruit:master Mar 1, 2023
@zvecr zvecr deleted the more_flashers branch March 3, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @hathach