Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ES3ink board #331

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add ES3ink board #331

merged 2 commits into from
Sep 12, 2023

Conversation

dronecz
Copy link
Contributor

@dronecz dronecz commented Jun 29, 2023

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

  • Please provide specific title of the PR describing the change
  • If you are adding an new boards, please make sure
    • Provide link to your allocated VID/PID if applicable
      Link
    • Add your board to action ci in correct workflow and alphabet order for release binary
    • UF2_BOARD_ID in your board.h follow correct format from uf2 specs

Description of Change

Add ES3ink board

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the PR template description and make following changes

  • UF2_BOARD_ID is not correct
  • remove adafruit favicon
  • provide link to vid/pid

- fix for UF2_BOARD_ID
- removed favicon
@dronecz
Copy link
Contributor Author

dronecz commented Jul 7, 2023

Please follow the PR template description and make following changes

  • UF2_BOARD_ID is not correct
  • remove adafruit favicon
  • provide link to vid/pid

I added link for VID/PID to PR comment and fixed issues which you mentioned. Thanks

@hathach
Copy link
Member

hathach commented Jul 7, 2023

I added link for VID/PID to PR comment and fixed issues which you mentioned. Thanks

your PID PR is still opened, have you allocated with the PID yet ?

@dronecz
Copy link
Contributor Author

dronecz commented Jul 7, 2023

your PID PR is still opened, have you allocated with the PID yet ?

Sorry, I do not now what you mean by that. Could you rephrase your question? Thanks

@hathach
Copy link
Member

hathach commented Jul 7, 2023

sorry, I mean did your request for the PID is accepted yet ?

@dronecz
Copy link
Contributor Author

dronecz commented Jul 7, 2023

No, I'm waiting for somebody to make a review, but I do not expect to be declined. I understand if you want wait until will be accepted.

@hathach
Copy link
Member

hathach commented Jul 7, 2023

No, I'm waiting for somebody to make a review, but I do not expect to be declined. I understand if you want wait until will be accepted.

PID approval is mandatory, I will mark this PR as draft for now. Please mark it as ready when you have PID allocated.

@hathach hathach marked this pull request as draft July 7, 2023 12:41
@lyusupov
Copy link
Contributor

your PID PR is still opened, have you allocated with the PID yet ?

Sorry, I do not now what you mean by that. Could you rephrase your question? Thanks

https://github.com/espressif/usb-pids

@dronecz dronecz marked this pull request as ready for review August 16, 2023 21:33
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you

@hathach hathach merged commit befecd0 into adafruit:master Sep 12, 2023
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants