Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Waveshare ESP32 S3 Pico #351

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Add Waveshare ESP32 S3 Pico #351

merged 4 commits into from
Oct 31, 2023

Conversation

tirtharajsinha
Copy link
Contributor

Request to add support for Waveshare ESP32 S3 Pico.
Circuitpython Support added.
VID/PID is provided by Espressif

0x81A2 | Waveshare ESP32-S3-Pico - UF2 Bootloader
0x81A3 | Waveshare ESP32-S3-Pico - CircuitPython

tirtharajsinha
tirtharajsinha commented Oct 29, 2023
View reviewed changes
Copy link
Contributor Author

@tirtharajsinha tirtharajsinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the arm board's workflow failed when there is no changed files that are arm related. I'm really confused right now.

hathach
hathach approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you. CI failed due to unrelated issue of python package (fixed in another PR).

@hathach hathach merged commit 2cb6fdf into adafruit:master Oct 31, 2023
85 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tirtharajsinha @hathach