Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp23 fix README.md reboot_to_uf2 #365

Merged
merged 2 commits into from
Dec 15, 2023
Merged

esp23 fix README.md reboot_to_uf2 #365

merged 2 commits into from
Dec 15, 2023

Conversation

s-light
Copy link
Contributor

@s-light s-light commented Dec 4, 2023

Description of Change

fixes the example in the usage section in the README.md for the expressif borads -
as at least i needed a static cast to esp_reset_reason_t to compile cleanly..

fixes the example - as at least i needed a static cast to esp_reset_reason_t to compile cleanly..
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change my mind, please change to C style cast, since static_cast is C++ only and application code may be pure C

changed cast style from c++ to c
@s-light
Copy link
Contributor Author

s-light commented Dec 14, 2023

done.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you

@hathach hathach merged commit 9389877 into adafruit:master Dec 15, 2023
109 checks passed
@s-light s-light deleted the patch-1 branch December 15, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants