New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKRZero board support #34
Conversation
boards/mkrzero/board_config.h
Outdated
|
||
#define BOARD_ID "SAMD21G18A-MKRZero-v0" | ||
|
||
//#define USB_VID 0x2341 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm what VID/PID is used if its not #defined'? we can assign one from the adafruit pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the Zero and MKR1000 had their VID/PID commented out, so I figured do the same to the MKRZero, as it's another Arduino board.
Without UF2 (e.g. running Blinky Arduino code):
VID: 2341
PID: 804F
With UF2 installed (no CircuitPython):
VID: 03EB
PID: 2402
With CircuitPython installed:
VID: 239A
PID: 8015
It looks like it's pulling from a default Atmel/Microchip (0x03EB VID) pool when it's just UF2 and it's getting 0x8015 from the Adafruit (0x239A) pool. Note that I'm loading Feather m0 Basic CircuitPython on it to test, so it might think it's a Feather m0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh ok yeah - alright hold on lets use these from Adafruit
MKRZero VID 0x239A PID 0x0035 # UF2 Bootloader
PID 0x8035 # CircuitPython
@ShawnHymel please use the VID/PIDs above for UF2 and then CircuitPython, and put a note "Adafruit VID/PID assigned to MKRZero for hobby use"
Would it make sense to submit a PR upstream to https://github.com/Microsoft/uf2-samdx1 ? The arduino zero and MKR1000 came from upstream. |
@dhalbert yah we should with our VID/PID pair - that way we dont get weird bootloader PID collisions, you really dont wanna use their bossac bootloader PID, ive had win7 driver trauma as you know :) |
@ladyada Updated VID/PID. Let me know if those look OK. |
thanks - done! |
Added MKRZero UF2 board files. @ladyada