Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces the sourceMap changes from #19 and adds a sourceMayRoot #20

Merged
merged 10 commits into from
Jun 3, 2013

Conversation

pathsny
Copy link
Contributor

@pathsny pathsny commented Jun 3, 2013

I'm sorry this has introduced so many commits many of which are me reverting changes I made and pushed to my repository, but this introduces 2 changes

  1. the changes made by @timvanelsloo that fixed sourceMaps has been introduced with changes made to the coffeescript file and the generated js file.
  2. added a new option called sourceMapRoot that adds a root the location of the sourceMap.

I had originally introduced 2 different options to do the same thing
i) inspectPrefix which would make sure the middleware only kicked in when the pathname to the js matched a specific prefix
ii) replacePrefix which would remove the prefix but add it back to the path to the sourceMap.
However, I realised that a lot of this can be accomplished automatically with expressjs since the first parameter to the use method of an express app is a static mount point. sourceMapRoot helps adjust the url exposed to the user

wdavidw added a commit that referenced this pull request Jun 3, 2013
introduces the sourceMap changes from #19 and adds a  sourceMayRoot
@wdavidw wdavidw merged commit fac62c2 into adaltas:master Jun 3, 2013
@wdavidw
Copy link
Member

wdavidw commented Jun 3, 2013

Perfect, thanks

@wdavidw wdavidw mentioned this pull request Jun 3, 2013
@wdavidw
Copy link
Member

wdavidw commented Jun 3, 2013

version 0.1.4 is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants