Depend on coffee-script 1.7.x #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updateSyntaxError is not in coffee-script 1.6.x, so we need to make sure to specify the coffee-script version.
|
i agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateSyntaxErroris not in coffee-script 1.6.x, so we need to make sure to specify the coffee-script version to 1.7.x. Depending on coffee-script version*can cause a problem if: top level project uses the latest version of node-connect-coffee-script, but also depends on coffee-script 1.6.x. Because of npm's dependency resolution, if it sees"coffee-script" : "*"in node-connect-coffee-script'spackage.json, it will think this is already satisfied with coffee-script 1.6.x and won't install the latest version. So if there is ever a syntax error, it won't show up properly becauseupdateSyntaxErrordoesn't exist.Also, in general I think it is a good idea to depend on a specific minor version of coffee-script because there might be breaking changes across versions that require updating this package.