ts: enable strict mode

adaltas · Nov 16, 2020 · 71faf94 · 71faf94
1 parent 987e978
commit 71faf94
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ Please join and contribute:
 
 ## Trunk
 
+* ts: enable strict mode
 * package: mocha inside package declaration
 
 ## Version 4.14.0

diff --git a/test/api.types.ts b/test/api.types.ts
@@ -50,9 +50,9 @@ describe('API Types', () => {
     })
 
     it('Receive Callback', (next) => {
-      parse('a\nb', function(err: Error, data: object, info: Info){
+      parse('a\nb', function(err: Error|undefined, records: object, info: Info){
         if(err !== undefined){
-          data.should.eql([['a'], ['b']])
+          records.should.eql([['a'], ['b']])
           info.records.should.eql(2)
         }
         next(err)
@@ -346,7 +346,7 @@ describe('API Types', () => {
     })
 
     it('Proper type is thrown when an error is encountered', () => {
-      parse(`a,b\nc`, function (e: Error) {
+      parse(`a,b\nc`, function (e: Error|undefined) {
         const isCsvError = e instanceof CsvError;
         isCsvError.should.be.true();
         (e as CsvError).code.should.eql('CSV_INCONSISTENT_RECORD_LENGTH');

diff --git a/tsconfig.json b/tsconfig.json
@@ -0,0 +1,8 @@
+{
+  "compileOnSave": false,
+  "compilerOptions": {
+    "target": "es6",
+    "moduleResolution": "node",
+    "strict": true,
+  }
+}