errors: expose CSV_OPTION_COLUMNS_MISSING_NAME

adaltas · Nov 1, 2019 · b76d470 · b76d470
1 parent a37dd48
commit b76d470
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 
 * errors: expose CSV_INVALID_ARGUMENT
 * errors: expose CSV_INVALID_COLUMN_DEFINITION
+* errors: expose CSV_OPTION_COLUMNS_MISSING_NAME
 * errors: expose CSV_INVALID_OPTION_BOM
 * errors: expose CSV_INVALID_OPTION_CAST
 * errors: expose CSV_INVALID_OPTION_CAST_DATE

diff --git a/lib/es5/index.js b/lib/es5/index.js
@@ -1257,7 +1257,7 @@ var normalizeColumnsArray = function normalizeColumnsArray(columns) {
       };
     } else if (isObject(column)) {
       if (typeof column.name !== 'string') {
-        throw new Error("Invalid Option columns: property \"name\" is required at position ".concat(i, " when column is an object literal"));
+        throw new CsvError('CSV_OPTION_COLUMNS_MISSING_NAME', ['Option columns missing name:', "property \"name\" is required at position ".concat(i), 'when column is an object literal']);
       }
 
       normalizedColumns[i] = column;

diff --git a/lib/index.js b/lib/index.js
@@ -1023,7 +1023,11 @@ const normalizeColumnsArray = function(columns){
       normalizedColumns[i] = { name: column }
     }else if(isObject(column)){
       if(typeof column.name !== 'string'){
-        throw new Error(`Invalid Option columns: property "name" is required at position ${i} when column is an object literal`)
+        throw new CsvError('CSV_OPTION_COLUMNS_MISSING_NAME', [
+          'Option columns missing name:',
+          `property "name" is required at position ${i}`,
+          'when column is an object literal'
+        ])
       }
       normalizedColumns[i] = column
     }else{

diff --git a/test/option.columns.coffee b/test/option.columns.coffee
@@ -13,7 +13,9 @@ describe 'Option `columns`', ->
         },{
           invalid: 'oh no'
         }], (->)
-      ).should.throw 'Invalid Option columns: property "name" is required at position 1 when column is an object literal'
+      ).should.throw
+        message: 'Option columns missing name: property "name" is required at position 1 when column is an object literal'
+        code: 'CSV_OPTION_COLUMNS_MISSING_NAME'
 
     it 'check the columns value', ->
       (->