feat: enforce usage of columns with columns_duplicates_to_array

adaltas · Apr 26, 2021 · d0e3471 · d0e3471
1 parent f714b89
commit d0e3471
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ Please join and contribute:
 
 ## Trunk
 
+* feat: enforce usage of columns with columns_duplicates_to_array
 * fix: update error message with invalid column type
 
 ## Version 4.15.4

diff --git a/lib/browser/index.js b/lib/browser/index.js
@@ -293,6 +293,8 @@ var Parser = /*#__PURE__*/function (_Transform) {
         options.columns_duplicates_to_array = false;
       } else if (options.columns_duplicates_to_array !== true) {
         throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', ['Invalid option columns_duplicates_to_array:', 'expect an boolean,', "got ".concat(JSON.stringify(options.columns_duplicates_to_array))], options);
+      } else if (options.columns === false) {
+        throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', ['Invalid option columns_duplicates_to_array:', 'the `columns` mode must be activated.'], options);
       } // Normalize option `comment`
 
 

diff --git a/lib/browser/sync.js b/lib/browser/sync.js
@@ -293,6 +293,8 @@ var Parser = /*#__PURE__*/function (_Transform) {
         options.columns_duplicates_to_array = false;
       } else if (options.columns_duplicates_to_array !== true) {
         throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', ['Invalid option columns_duplicates_to_array:', 'expect an boolean,', "got ".concat(JSON.stringify(options.columns_duplicates_to_array))], options);
+      } else if (options.columns === false) {
+        throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', ['Invalid option columns_duplicates_to_array:', 'the `columns` mode must be activated.'], options);
       } // Normalize option `comment`
 
 

diff --git a/lib/es5/index.js b/lib/es5/index.js
@@ -185,6 +185,8 @@ var Parser = /*#__PURE__*/function (_Transform) {
         options.columns_duplicates_to_array = false;
       } else if (options.columns_duplicates_to_array !== true) {
         throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', ['Invalid option columns_duplicates_to_array:', 'expect an boolean,', "got ".concat(JSON.stringify(options.columns_duplicates_to_array))], options);
+      } else if (options.columns === false) {
+        throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', ['Invalid option columns_duplicates_to_array:', 'the `columns` mode must be activated.'], options);
       } // Normalize option `comment`
 
 

diff --git a/lib/index.js b/lib/index.js
@@ -120,6 +120,11 @@ class Parser extends Transform {
         'expect an boolean,',
         `got ${JSON.stringify(options.columns_duplicates_to_array)}`
       ], options)
+    }else if(options.columns === false){
+      throw new CsvError('CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY', [
+        'Invalid option columns_duplicates_to_array:',
+        'the `columns` mode must be activated.'
+      ], options)
     }
     // Normalize option `comment`
     if(options.comment === undefined || options.comment === null || options.comment === false || options.comment === ''){

diff --git a/test/option.columns_duplicates_to_array.coffee b/test/option.columns_duplicates_to_array.coffee
@@ -10,10 +10,19 @@ describe 'Option `columns_duplicates_to_array`', ->
     ).should.throw
       code: 'CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY'
       message: [
-        'Invalid option columns_duplicates_to_array:',
+        'Invalid option columns_duplicates_to_array:'
         'expect an boolean, got "invalid"'
       ].join ' '
 
+  it 'require columns to be active', ->
+    (->
+      parse "", columns_duplicates_to_array: true
+    ).should.throw
+      code: 'CSV_INVALID_OPTION_COLUMNS_DUPLICATES_TO_ARRAY'
+      message: [
+        'Invalid option columns_duplicates_to_array:'
+        'the `columns` mode must be activated.'
+      ].join ' '
 
   it 'when false', (next) ->
     parse """