fix(csv-stringify): throw err with no records and header in sync mode

adaltas · Jun 14, 2022 · 5c8ef2e · 5c8ef2e
1 parent 851a129
commit 5c8ef2e
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 10 deletions.
diff --git a/packages/csv-stringify/dist/cjs/sync.cjs b/packages/csv-stringify/dist/cjs/sync.cjs
@@ -546,9 +546,10 @@ const stringify = function(records, opts={}){
     api.bom((d) => {
       data.push(d);
     });
-    api.headers((headers) => {
+    const err = api.headers((headers) => {
       data.push(headers);
     });
+    if(err !== undefined) throw err;
   }
   return data.join('');
 };

diff --git a/packages/csv-stringify/dist/esm/sync.js b/packages/csv-stringify/dist/esm/sync.js
@@ -2514,9 +2514,10 @@ const stringify = function(records, opts={}){
     api.bom((d) => {
       data.push(d);
     });
-    api.headers((headers) => {
+    const err = api.headers((headers) => {
       data.push(headers);
     });
+    if(err !== undefined) throw err;
   }
   return data.join('');
 };

diff --git a/packages/csv-stringify/dist/iife/sync.js b/packages/csv-stringify/dist/iife/sync.js
@@ -2517,9 +2517,10 @@ var csv_stringify_sync = (function (exports) {
                 api.bom((d) => {
                   data.push(d);
                 });
-                api.headers((headers) => {
+                const err = api.headers((headers) => {
                   data.push(headers);
                 });
+                if(err !== undefined) throw err;
               }
               return data.join('');
             };

diff --git a/packages/csv-stringify/dist/umd/sync.js b/packages/csv-stringify/dist/umd/sync.js
@@ -2520,9 +2520,10 @@
                 api.bom((d) => {
                   data.push(d);
                 });
-                api.headers((headers) => {
+                const err = api.headers((headers) => {
                   data.push(headers);
                 });
+                if(err !== undefined) throw err;
               }
               return data.join('');
             };

diff --git a/packages/csv-stringify/lib/sync.js b/packages/csv-stringify/lib/sync.js
@@ -27,6 +27,7 @@ const stringify = function(records, opts={}){
     const err = api.headers((headers) => {
       data.push(headers);
     });
+    if(err !== undefined) throw err;
   }
   return data.join('');
 };

diff --git a/packages/csv-stringify/samples/option.cast.js b/packages/csv-stringify/samples/option.cast.js
@@ -2,12 +2,12 @@
 import assert from 'assert';
 import { stringify } from 'csv-stringify/sync';
 
-const data = stringify( [ [1], [2] ], {
+const data = stringify([ [1], [2] ], {
   cast: {
     number: function(value){
-      return {value: `="${value}"`, quote: false}
+      return {value: `="${value}"`, quote: false};
     }
   }
-})
+});
 
-assert.equal(data, '="1"\n="2"\n')
+assert.equal(data, '="1"\n="2"\n');
diff --git a/packages/csv-stringify/test/api.web_stream.coffee b/packages/csv-stringify/test/api.web_stream.coffee
@@ -2,9 +2,9 @@
 # import {generate as generateStream} from 'csv-generate/stream'
 # import {stringify as stringifyStream} from '../lib/stream.js'
 # import {stringify as stringifyClassic} from '../lib/index.js'
-# 
+#
 # describe 'api stream', ->
-# 
+#
 #   it.skip 'perf stream with iterator', ->
 #     generator = generateStream
 #       objectMode: true,