The example on the readme is slightly incorrect, and will result in intermittent failures. #94

Merged
merged 1 commit into from Apr 26, 2013

Conversation

Projects
None yet
2 participants
@chuggins
Contributor

chuggins commented Apr 25, 2013

As per the documentation in to.js, it is incorrect to rely on the 'end' event when writing to a file. Utilize 'close' instead.

Update readme example to correctly handle files
As per the documentation in to.js, it is incorrect to rely on the 'end' event when writing to a file.  Utilize 'close' instead.

wdavidw pushed a commit that referenced this pull request Apr 26, 2013

Worms David
Merge pull request #94 from chuggins/master
The example on the readme is slightly incorrect, and will result in intermittent failures.

@wdavidw wdavidw merged commit b654695 into adaltas:master Apr 26, 2013

1 check failed

default The Travis build could not complete due to an error
Details
@wdavidw

This comment has been minimized.

Show comment Hide comment
@wdavidw

wdavidw Apr 26, 2013

Collaborator

This is right, thks

Collaborator

wdavidw commented Apr 26, 2013

This is right, thks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment