Fixed assignment bugs on extending a model. Fixes #5, #6

adam-cowley · May 21, 2018 · ccae12b · ccae12b
1 parent bdab560
commit ccae12b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/build/ModelMap.js b/build/ModelMap.js
@@ -23,7 +23,7 @@ var ModelMap = function () {
     /**
      * @constuctor
      *
-     * @param {Neode} neode 
+     * @param {Neode} neode
      */
     function ModelMap(neode) {
         _classCallCheck(this, ModelMap);
@@ -34,7 +34,7 @@ var ModelMap = function () {
 
     /**
      * Getter
-     * 
+     *
      * @param  {String}
      * @return {Model|false}
      */
@@ -48,7 +48,7 @@ var ModelMap = function () {
 
         /**
          * Setter
-         * 
+         *
          * @param  {String} key
          * @param  {Model}  value
          * @return {ModelMap}
@@ -64,7 +64,7 @@ var ModelMap = function () {
 
         /**
          * Run a forEach function on the models
-         * 
+         *
          * @param  {Function}
          * @return {void}
          */
@@ -77,7 +77,7 @@ var ModelMap = function () {
 
         /**
          * Get the definition for an array labels
-         * 
+         *
          * @param  {Array} labels
          * @return {Definition}
          */
@@ -125,7 +125,7 @@ var ModelMap = function () {
 
         /**
          * Extend a model with extra configuration
-         * 
+         *
          * @param  {String} name   Original Model to clone
          * @param  {String} as     New Model name
          * @param  {Object} using  Schema changes
@@ -139,8 +139,8 @@ var ModelMap = function () {
             var original = this.models.get(name);
 
             // Add new Labels
-            var labels = original.labels();
-            labels.push(name);
+            var labels = original.labels().slice(0);
+            labels.push(as);
             labels.sort();
 
             // Merge Schema

diff --git a/src/ModelMap.js b/src/ModelMap.js
@@ -5,7 +5,7 @@ export default class ModelMap {
     /**
      * @constuctor
      *
-     * @param {Neode} neode 
+     * @param {Neode} neode
      */
     constructor(neode) {
         this._neode = neode;
@@ -14,7 +14,7 @@ export default class ModelMap {
 
     /**
      * Getter
-     * 
+     *
      * @param  {String}
      * @return {Model|false}
      */
@@ -24,7 +24,7 @@ export default class ModelMap {
 
     /**
      * Setter
-     * 
+     *
      * @param  {String} key
      * @param  {Model}  value
      * @return {ModelMap}
@@ -37,7 +37,7 @@ export default class ModelMap {
 
     /**
      * Run a forEach function on the models
-     * 
+     *
      * @param  {Function}
      * @return {void}
      */
@@ -47,7 +47,7 @@ export default class ModelMap {
 
     /**
      * Get the definition for an array labels
-     * 
+     *
      * @param  {Array} labels
      * @return {Definition}
      */
@@ -69,7 +69,7 @@ export default class ModelMap {
 
     /**
      * Extend a model with extra configuration
-     * 
+     *
      * @param  {String} name   Original Model to clone
      * @param  {String} as     New Model name
      * @param  {Object} using  Schema changes
@@ -80,8 +80,8 @@ export default class ModelMap {
         const original = this.models.get(name);
 
         // Add new Labels
-        const labels = original.labels();
-        labels.push(name);
+        const labels = original.labels().slice(0);
+        labels.push(as);
         labels.sort();
 
         // Merge Schema
@@ -96,5 +96,5 @@ export default class ModelMap {
 
         return model;
     }
-    
+
 }