Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome plugin inserts an additional blank line at the top of Gmail #243

Closed
JamesMcMahon opened this issue Feb 2, 2015 · 4 comments
Closed

Comments

@JamesMcMahon
Copy link

When using the current Chrome plugin (2.11.3) toggling Mardown mode in a Gmail will insert a space at the top of the email. It effectively looks like an additional line of whitespace, but this line is not removable.

Here is an example, before:
screen shot 2015-02-02 at 5 26 44 pm

After:
screen shot 2015-02-02 at 5 26 59 pm

This is on Chrome 40.0.2214.94 on Mac OS X (10.10.2).

Let me know if any more information is needed.

@JamesMcMahon JamesMcMahon changed the title Chrome plugin inserts an additional blank line at the top of email Chrome plugin inserts an additional blank line at the top of Gmail Feb 2, 2015
@adam-p adam-p added this to the Next release milestone Mar 10, 2015
@adam-p
Copy link
Owner

adam-p commented Mar 10, 2015

I have noticed this, but I guess I stopped seeing it after a while. I'll fix it in the next release.

You can fix it yourself by adding this to your "Primary Styling CSS" in the MDH Options, below the existing p rule (so, it's fine if you just add it to the bottom):

.markdown-here-wrapper:first-of-type > p:first-of-type {
  margin-top: 0 !important; 
}

(I adapted that from the Salutation Styling on our Hints and Tips wiki page.)

Does that fix it for you?

@JamesMcMahon
Copy link
Author

That fix does work, thanks!

Is that something that can be fixed for everyone in future versions of the plugin?

@adam-p
Copy link
Owner

adam-p commented Mar 11, 2015

Yes. I think it's an improvement, so I'll add it to the default CSS in the next release. (Unfortunately, people will have to reset their CSS to get the change. Blah. Dumb design. #48, #78.)

@adam-p adam-p closed this as completed in 972198c Mar 20, 2015
@adam-p
Copy link
Owner

adam-p commented Mar 20, 2015

In my fix I made an even simpler change -- I just got rid of the top margin altogether. The <p> rule is now:

p {
  margin: 0 0 1.2em 0 !important;
}

(Also note that in the CSS I suggested earlier, the .markdown-here-wrapper:first-of-type is meaningless -- :first-of-type can't be used with classes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants