Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options page is broken in Firefox and Thunderbird 17 #37

Closed
adam-p opened this issue Nov 30, 2012 · 1 comment
Closed

Options page is broken in Firefox and Thunderbird 17 #37

adam-p opened this issue Nov 30, 2012 · 1 comment
Labels
bug high

Comments

@adam-p
Copy link
Owner

adam-p commented Nov 30, 2012

The editable fields aren't being filled in, and the preview frame isn't working. There are no errors in the JS console.

I'm not yet sure what the problem is, but I'll try to sort it out quickly.

If anyone has any insight, feel free to chime in.
adam-p added a commit that referenced this issue Dec 1, 2012
@adam-p
Fixed issue #37: Options page wasn't working in Firefox 17 and Thunde…
57873e9 
…rbird 17.
@adam-p
Copy link
Owner Author

adam-p commented Dec 1, 2012

Breakage was due to this change in Firefox/Thunderbird 17:
https://blog.mozilla.org/addons/2012/08/20/exposing-objects-to-content-safely/

Yes, I saw the warning in previous versions and ignored it.

@adam-p adam-p closed this as completed Dec 1, 2012
adam-p added a commit that referenced this issue Jan 2, 2013
@adam-p
Fixed bug #37 again: Options page was broken in Firefox/Thunderbird. …
5fcf89e 
…The previous fix was insufficient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam-p