Wrong view of markdown icon in Firefox toolbar

[ynoxia]

Hi,

after installing your addon for Firefox, I constantly have this behaviour in firefox main toolbar:

After Wikipedia textbox, all the icons you see is related to markdown here. These icons are one after another, but they are all related to your markdown here addon. Indeed, if I move my mouse over them, i read tip the selected field is not valid for markdown rendering.

Can't remove it from toolbar. Restarting Firefox, I see it again in the same place and in the same way.

Firefox 19.0 - Fedora Linux 18

Thank you.

[jljouannic]

Same problem here. Firefox 19.0 - Ubuntu 12.04

[adam-p]

Fixed in rev 605cce2. Will be in next release (which will be pretty soon, since this bug is craptastic). Note that this only affects Firefox on Linux (not sure if it's only Firefox v19 -- didn't test on earlier versions).

The problem is that the default Firefox toolbar button styles were getting applied with higher precedence than the Markdown Here custom styles -- specifically, the button icon was getting overridden. I really don't know why this was the case, nor why it only happened on Linux.

I fixed it by using the button id in the CSS rules rather than the class -- which has the effect of making them higher-specificity rules, and therefore of higher precedence than the default button class rules.

There are a couple of other things I've fixed that are also somewhat related to this bug (mostly they exacerbated it):

• As @ynoxia mentioned, the button was being forcibly re-added to the toolbar, even when it was being manually removed. This was being caused by debug code that never should have been checked in (i.e., if (true || ...)). Fixed in rev 3d21a5f.
• The button wasn't appearing disabled on Linux (when it was actually disabled -- like, not greyed out or anything). Again, not sure why it's different than on Windows/OSX. This is fixed in rev 4343867 (although I might go back and tweak the exact degree of grayscale).

(Sorry for the delay in responding -- I was away for a week.)

[adam-p]

Confirmed in Firefox 18.0.1 on Xubuntu.

[adam-p]

New version has been submitted to Mozilla. You can wait for the review to finish and get the auto-upgrade (if you haven't already uninstalled the extension, which surely you have), or you can force the installation of the new version here:
https://addons.mozilla.org/en-US/firefox/addon/markdown-here/versions/

[ynoxia]

Thank you, Adam. I surely update with your latest version of this great addon. 👍

[ynoxia]

Just a very very very cosmetic question. The Markdown Here icon has a white background, instead of a transparent one that other browser icons generally have. Is it a behaviour you want, or just a little slip?

[adam-p]

It's intentional... mostly.

When the button is enabled: The logo designer and I found that the icon wasn't visible enough with a transparent background, especially if the browser had a noisy theme. This is largely because the shape of the logo isn't very square or round like many other button icons. So we gave it a 75% opaque background to help it stand out.

When the button is disabled: It looks pretty messed up on Linux Firefox, but only Linux. On Windows and OSX the button looks properly disabled, but on Linux there's no automatic alteration of the button. I added some styles so that the button is at least gray when disabled, but it still doesn't look the same. I also tried adding an opacity style, which looks better on Linux, but then it's too transparent on Windows/OSX. And then I decided that I'd better get the fix released for that Linux button disaster. I might try some more stuff to make it look better sometime (OS-specific styles; reverse engineer some other extensions; ...).

Does that answer the question?

[ynoxia]

Yes, Adam, thank you.

It's only a cosmetic stuff that does not affect the usefulness of your addon.

I have installed your new version and by now it's all OK. 👍