Capable robot cq1 pythonocc #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osterwood @justbuchanan could you help me verifying that this PR works with cqparts? |
|
I tried it out and in combination with the capablerobot fork of cqparts, it seems to work really well. There are still some cqparts tests failing, but I think those can be fixed separately from what's in this PR. We'll also need to make some more changes to cqparts as well. For reference, I attached the test log below. I used this branch of cadquery plus a few hacks and managed to get cqparts assemblies rendering in cq-editor. Here's a screenshot of the toy car example from cqparts.
|
|
Wow, that looks great. I am going to merge. BTW: I see quite some errors on the cqparts side related to direct usage of FreeCAD/.wrapped . That should easy to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.