Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include light font weight in Delugia #45

Closed
offero opened this issue Sep 25, 2020 · 8 comments
Closed

Include light font weight in Delugia #45

offero opened this issue Sep 25, 2020 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@offero
Copy link

offero commented Sep 25, 2020

Terminal config:

          "fontFace" : "Delugia Nerd Font",
           "fontWeight": "light",
           "fontSize" : 10,

Results in bold font

@Finii
Copy link
Collaborator

Finii commented Sep 28, 2020

There is no Delugia Nerd Font light.
Which 'Terminal' are you using, that you can select 'light'? I can't.

Usually you can select bold or italic even if not supplied by the font, but I never heard of an autogenerated light.

Screenshot from 2020-09-28 08-35-43

@offero
Copy link
Author

offero commented Sep 28, 2020

I'm using the latest Cacadia Code PL

Terminal: https://github.com/microsoft/terminal

Settings:

            "fontFace" : "Cascadia Mono PL",
            "fontWeight": "light",
            "fontSize" : 10,

image

@Finii
Copy link
Collaborator

Finii commented Sep 28, 2020

For questions about Cascadia Code, please head over to https://github.com/microsoft/cascadia-code.

If you open Delugia in your font settings dialog, note that there is no light or other weights, just regular.

Capture

I guess you manually typed in light in the terminal settings file?

@offero
Copy link
Author

offero commented Sep 29, 2020

Gotcha. Consider this issue a request to include the light variant then.

@adam7 adam7 changed the title light font weight does not work Include light font weight in Delugia Oct 6, 2020
@adam7 adam7 added help wanted Extra attention is needed enhancement New feature or request labels Oct 7, 2020
@Finii
Copy link
Collaborator

Finii commented Feb 15, 2021

In fact I noticed this would be easy (while working on Artur's PR).
What shall we do? All (now 5) fonts also in light?
Where to end, there are 5 weights for each ... 😬

@Finii
Copy link
Collaborator

Finii commented Feb 15, 2021

Explanation: I think we can not handle the multi-weight font files; either because a fontforge limitation or because limited know how to operate that on my side. But we can generate dedicated files for each weight, as Microsoft does in its static/ subdir.

@adam7
Copy link
Owner

adam7 commented Mar 22, 2021

I think you're right @Finii we should generate all the fonts 😬

@Finii
Copy link
Collaborator

Finii commented Jul 2, 2021

I guess this can be closed? Please reopen if this is still an issue with release v2105.24.2.

@Finii Finii closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants