Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed as 2 different fonts #72

Closed
rashil2000 opened this issue Dec 5, 2021 · 6 comments
Closed

Installed as 2 different fonts #72

rashil2000 opened this issue Dec 5, 2021 · 6 comments
Labels
confirmed Issue could be reproduced

Comments

@rashil2000
Copy link

Hey!

I used to painstakingly patch Cascadia Code manually to include Nerd glyphs, before I found this repo. Many thanks for this!

But I'm facing a similar issue that I faced with Caskaydia (nerd font version of Cascadia) - when installing, two fonts show up:

image

image

image

Is this expected? Shouldn't the Light variant show up along with Regular and Bold in the Delugia font itself?


For now, I manually edited family name in the font files DelugiaCompleteLight.ttf and DelugiaCompleteLight-Italic.ttf from "Delugia Light" to "Delugia" in Fontforge and then installed it to solve the issue.

Screenshot 2021-12-06 005333
Screenshot 2021-12-06 005343

@Finii
Copy link
Collaborator

Finii commented Dec 6, 2021

Thanks for reporting. I can fix it for Delugia in the afternoon.

To fix it generally for font-patcher we need something like #706 . In fact Cascadia (and other full blown fonts) and their problems with font-patcher is my driver for that time consuming project.

@rashil2000
Copy link
Author

Thank you for the info!

@Finii Finii added the confirmed Issue could be reproduced label Dec 6, 2021
@Finii
Copy link
Collaborator

Finii commented Dec 6, 2021

Well, now it is fixed.

In applications that support Typographic Families they will show up as packs of 6, in 'old fashioned' applications they will show up as 6 times 4 (regular, bold, italic, bold italic) and 6 times 2 (light, light italic).

image

I will upload the code and refresh the repo ... soon ;)

@rashil2000
Copy link
Author

Thanks again for the fix, and for Delugia 😅

Should I close this?

@Finii
Copy link
Collaborator

Finii commented Dec 6, 2021

Will be auto-closed by the merge... :-)

@Finii Finii closed this as completed in f041a01 Dec 7, 2021
@Finii
Copy link
Collaborator

Finii commented Dec 7, 2021

Hmm, although this fixes it, it is not as intended, ... will push another tweak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue could be reproduced
Projects
None yet
Development

No branches or pull requests

2 participants