fixed notification bug

adamalbrecht · Jul 3, 2013 · c54f9d8 · c54f9d8
1 parent 924f1a5
commit c54f9d8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 19 deletions.
diff --git a/manifest.json b/manifest.json
@@ -11,7 +11,7 @@
     "default_popup": "popup.html"
   },
 	"background": {
-    "pages": ["background.html"]
+    "page": "background.html"
   },
 	"options_page":"options.html",
   "permissions": [

diff --git a/notification.html b/notification.html
@@ -10,25 +10,9 @@
 </style>
 <script src="core.js"></script>
 <script src="json2.js"></script>
-<script>
-  function SetupNotification() {
-    var link = JSON.parse(localStorage['HN.Link0']);
-    var storyLink = document.getElementById("StoryLink");
-    storyLink.href = link.Link;
-    storyLink.innerText = link.Title;
-    storyLink.addEventListener("click", openLinkFront);
-
-    var commentsLink = document.getElementById("CommentsLink");
-    commentsLink.href = link.CommentsLink;
-    commentsLink.addEventListener("click", openLinkFront);
-
-    setTimeout(function() {
-        window.close();
-    }, 10000);
-  }
-</script>
+<script src="notification.js"></script>
 </head>
-<body onLoad="SetupNotification()">
+<body>
   <div id="header">
     <img src="icon18.gif"/>
     <span>Hacker News Top Story</span>

diff --git a/notification.js b/notification.js
@@ -0,0 +1,19 @@
+function SetupNotification() {
+    var link = JSON.parse(localStorage['HN.Link0']);
+    var storyLink = document.getElementById("StoryLink");
+    storyLink.href = link.Link;
+    storyLink.innerText = link.Title;
+    storyLink.addEventListener("click", openLinkFront);
+
+    var commentsLink = document.getElementById("CommentsLink");
+    commentsLink.href = link.CommentsLink;
+    commentsLink.addEventListener("click", openLinkFront);
+
+    setTimeout(function() {
+        window.close();
+    }, 10000);
+}
+
+document.addEventListener('DOMContentLoaded', function () {
+  SetupNotification();
+});