Add array for CPU and GPU #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stvdwtt
reviewed
Aug 4, 2021
source/ArrayMD.hh
Outdated
| } | ||
|
|
||
| /** | ||
| * Five-dimensional array with akk dimension set at compile-time. |
There was a problem hiding this comment.
Suggested change
| * Five-dimensional array with akk dimension set at compile-time. | |
| * Five-dimensional array with all dimensions set at compile-time. |
|
@Rombur, was that comment the only thing you changed in the push an hour ago? I can't figure out how to see a diff from the original commit from yesterday. |
|
Yes, sorry I just amended the last commit since it was a small change. |
|
Sounds good -- just wanted to double-check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new data structures:
Array2D,Array3D,Array4D, andArray5DThe memory space where the data is stored is determined by the last template parametersMemorySpaceType. The dimensions of theArraycan be set at compile time using a template parameter or at run-time. In that last case, the template parameter should be set to-1. Note that I didn't implement all the combinations of compile/run-time parameters. I've implemented the one that I use in other parts of the code.