Fix parsing of the elastic limit #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is the same issue here: https://github.com/stvdwtt/adamantine/blob/c2e5642b1142f6856246c722a69f42c060ee0744/source/MaterialProperty.templates.hh#L923-L927 |
|
Retest this please. |
Rombur
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaterialProperty was checking each state for
elastic_limit, and setting it to infinity if it wasn't there. The result was that the elastic limit for the solid was ignored.This changes the logic so MaterialProperty only sets the elastic limit to infinity if it isn't listed for the solid.