Make MaterialProperty::polynomial_order a template parameter #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using a polynomial description of the material properties, we assume that we have a polynomial of order four. This is often not the case and we end up wasting a lot of flops. This PR makes the polynomial order a template parameter. The correct order is computed at runtime by doing a first read of the material parameters before calling
MaterialProperties
. The new template parameterp_order
propagates everywhere because we need to templateMaterialProperties
and almost every class owns a reference toMaterialProperties
.