Increase flexibility in creating meshes and loading meshes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
reviewed
Mar 15, 2024
README.md
Outdated
| * if import\_mesh is false: | ||
| * length: the length of the domain in meters (required) | ||
| * height: the height of the domain in meters (required) | ||
| * width: the width of the domain in meters (only in 3D) | ||
| * length_origin: the reference location in the length direction (default value: 0) |
There was a problem hiding this comment.
Suggested change
| * length_origin: the reference location in the length direction (default value: 0) | |
| * length\_origin: the reference location in the length direction (default value: 0) |
README.md
Outdated
| * if import\_mesh is false: | ||
| * length: the length of the domain in meters (required) | ||
| * height: the height of the domain in meters (required) | ||
| * width: the width of the domain in meters (only in 3D) | ||
| * length_origin: the reference location in the length direction (default value: 0) | ||
| * height_origin: the reference location in the height direction (default value: 0) |
There was a problem hiding this comment.
Suggested change
| * height_origin: the reference location in the height direction (default value: 0) | |
| * height\_origin: the reference location in the height direction (default value: 0) |
README.md
Outdated
| * if import\_mesh is false: | ||
| * length: the length of the domain in meters (required) | ||
| * height: the height of the domain in meters (required) | ||
| * width: the width of the domain in meters (only in 3D) | ||
| * length_origin: the reference location in the length direction (default value: 0) | ||
| * height_origin: the reference location in the height direction (default value: 0) | ||
| * width_origin: the reference location in the width direction (only in 3D) (default value: 0) |
There was a problem hiding this comment.
Suggested change
| * width_origin: the reference location in the width direction (only in 3D) (default value: 0) | |
| * width\_origin: the reference location in the width direction (only in 3D) (default value: 0) |
README.md
Outdated
| @@ -105,10 +105,15 @@ The following options are available: | |||
| * mesh\_format: abaqus, assimp, unv, ucd, dbmesh, gmsh, tecplot, xda, vtk, | |||
| vtu, exodus, or default, i.e., use the file suffix to try to determine the | |||
| mesh format (required) | |||
| * mesh\_scale\_factor: Apply a uniform scaling factor to the mesh (e.g. if the mesh is defined in mm or inches instead of m), (default value: 1) | |||
| * set\_material\_id\_to\_0: Clear the material IDs defined in the mesh and sets them all to zero: true or false (default value: false) | |||
There was a problem hiding this comment.
I think I would call this something like set_material_id or set_uniform_material_id. Use don't need to know/don't care which value we are using.
There was a problem hiding this comment.
How about reset_material_id, and then mention that we set it to zero in the description? I think the value being zero is important because it corresponds to the material_0 material input block.
Suggested change
| * set\_material\_id\_to\_0: Clear the material IDs defined in the mesh and sets them all to zero: true or false (default value: false) | |
| * reset\_material\_id: Clear the material IDs defined in the mesh and set them all to zero so all material properties are given by the `material\_0` input block: true or false (default value: false) |
Rombur
reviewed
Mar 18, 2024
source/Geometry.cc
Outdated
|
|
||
| // Set the mesh material id to 0 if specified in the input | ||
| // PropertyTreeInput geometry.set_material_id_to_0 | ||
| auto reset_material_id = database.get("set_material_id_to_0", false); |
There was a problem hiding this comment.
Thanks for catching that! Fixed
Rombur
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of two PRs to let us do the curved wall build for the Okuma. This one is focused on relaxing the assumption that the entire domain is in the +x, +y, +z octant. A common AM reference frame has the top of the substrate centered at (0, 0, 0).
Changes: