Print all deal.II configurations problems before aborting #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to print all the configuration issues at once, then accumulate the options that are not satisfied in one string and print one error message. With this PR, we are printing the same sentence many times over, only is a single word is changed. Moreover the last sentence does not give any new information, it just fills the screen. |
Rombur
reviewed
May 20, 2024
cmake/SetupDealII.cmake
Outdated
| foreach(FEATURE ${DEAL_II_REQUIRED_FEATURES}) | ||
| if(NOT DEAL_II_WITH_${FEATURE}) | ||
| list(APPEND DEAL_II_MISSING_FEATURES ${FEATURE}) | ||
| set(DEAL_II_HAS_ALL_DEPENDENCIES FALSE) |
Rombur
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to reconfigure deal.II multiple times since I didn't look into the file that checks the configuration. It's easier to print all the configuration problems at once.