FEATURE: Add fetching watch providers to movie and tv series services #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEATURE: Add tv show tagline
FIX: linting
# Conflicts: # Sources/TMDb/Models/TVSeries.swift
|
Hey @Tuikku. Thanks for your PR. Did you see there is already a WatchProviders service that does this? https://github.com/adamayoung/TMDb/blob/main/Sources/TMDb/WatchProviders/WatchProviderService.swift |
|
Does this fetch the actual providers for individual series or movie? I think the service you linked just fetches all available for the region. |
|
Ahhh, i understand now. Thanks for this. Would appreciate you adding some unit tests around the changes you've made 🙏🏻 |
|
Yeah, I'll add some tests to this pr. |
|
Added some unit tests, let me know what you think. Didn't add integration tests since watch providers for tv series or movie could change. |
adamayoung
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.